search

freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!
https://securedrop.org/
Other
3.63k stars 685 forks source link

Update Alt Tag on Newsroom Logo #4280

Open ninavizz opened 5 years ago

ninavizz commented 5 years ago

Description

Sought Immediate Action: Pls update <alt> tag on Newsroom Logo in Source UI to read Logo Image and not SecureDrop

Currently there is no mention of the name of a newsroom on an instance of SecureDrop. This presents two core problems for Sources, in the Source Experience.

  1. The <alt> on the newsroom logo today, is currently SecureDrop. That's strange and misleading. See 0:20 and 0:30 in this video screencast of AlJazeera's SecureDrop loading w/in Tor. A minimum/asap fix, would be updating the static <alt> w/in the code to read Newsroom Logo (sidenote: alt tags are a big accessibility thing, on an aside from also informing users what's what as assets load).

  2. Longer term, the Admin interface should be updated to accept the newsroom's name (including the word The for orgs such as The Intercept or The New York Times) and that alt-tag should be dynamically generated to read <%NewsOrgName%> Logo

User Research Evidence

User Stories

As a Source I want to be less confused about who I'm submitting my stuff to, and what this SecureDrop thing is.

ninavizz commented 5 years ago

Hmmm, seems we just got report submitted from Accessibility lab thaaaat seems to validate this? Could the simple update to the alt tag pls to get included in the 0.13 release? 😃 @eloquence

Dynamic inclusion of the newsroom's name can be addressed in a subsequent ticket. Once we have the newsroom's name added to the admin interface, of course. And unicorns deliver burritos to my house from Mars.

ninavizz commented 5 years ago

Bumpitty bump! Could this get a "Help Wanted" tag, and perhaps moved to "Near Term Backlog" per this AM's UX meeting? /cc @eloquence

eloquence commented 5 years ago

Happy to do so. Given latency in Tor, this ALT text does stick around for a while, and I agree there's some potential for confusion depending on what logo is actually set.

How would you feel about "Logo Image" instead of just "Logo", at least until we qualify it with the newsroom name? The text "Logo" hovering for a few seconds I think has its own potential to look a bit confusing.

ninavizz commented 5 years ago

Updated instructions in OG comment, accordingly—thx for the sound suggestion, Erik!

drewmassey commented 5 years ago

Picking this up this week at @ninavizz 's reccomendation

drewmassey commented 5 years ago

Per convo in PR #4494 I am tabling this until I look at #4480.

DrGFreeman commented 5 years ago

I'm picking this one up as suggested by @zenmonkeykstop on Gitter.

I'll submit a PR shortly that just changes the static <alt> tag from SecureDrop to Logo Image (the short term fix as described above). Then I can look into a longer term solution that dynamically generate the tag using the news organization name.

ninavizz commented 5 years ago

@DrGFreeman There is not currently a value in the Admin UI for an org to set their name; that would have to be added, for an alt tag to dynamically generate. At some point in the next year, I'd like to see that value added into the Admin UI and into the data tables... but for now, it's not a high enough priority to merit the testing that'd be required to make it possible. Unless someone else on the team disagrees. THANK YOU for the small change to Logo Image however, that's a big usability help—and something I'd thought had already been taken care of. :)

eloquence commented 4 years ago

The first part of this issue was completed in #4980. As mentioned above, further work on this is is blocked until we add support for setting the organizational name in the Admin Interface (#1575).