Closed ninavizz closed 4 years ago
To be considered with #4967
Hi @ninavizz.
I can work on implementing this. Implementing the message cycling will be quite straightforward provided we replace the different messages that depend on the type of submission (file, message or both) with the more generic "this information / additional information" as per your suggestion above.
Regarding the styling, I can implement easily in the current flash message style, with the changing part of the message in bold like below.
I believe updating the style of the flash messages should be treated separately as it would affect not only these messages but all flash messages messages.
Hello @DrGFreeman! I would personally love it if you took this on... however we have yet to discuss the solution, as a team. A few things...
Ok, I'll step-back from trying to read @eloquence or @redshiftzero's minds. They'll both be online in the AM (PST), and I'm sure will be happy to get your brain working on something.
It's great seeing you back, and I look forward to working with you some more on things! :)
@ninavizz, FYI I already have the message rotation working in a local branch so, apart from the PR review effort by the SD team (which I understand is not negligible), getting this change in would not take much off from my capacity to work on another issue that maybe more of a priority.
I understand the multi-file upload is a much more complex change, subject to team agreement on priorities. In this context, I believe implementing the message rotation would provide a worthwile initial solution to the problem raised by Freddy Martinez.
It's great seeing you back, and I look forward to working with you some more on things! :)
The pleasure is mine!
I have concerns about maintenance and translation burden for this message rotation approach, especially with 4 messages. (Remember that we have to have automated tests for this as well.) I'm also not convinced the subtle variations of content are sufficient to help the user distinguish between subsequent upload actions; this is not an established design pattern, and I'm wary of introducing it into the UX untested.
While we can't safely use JavaScript in the Source Interface, we can use CSS. I would rather explore setting a one-time CSS on-load animation to highlight the message visually, instead of changing the message content.
Hi @eloquence, Thanks for the feedback.
From the maintenance perspective, I think this is roughly equivalent, as there are already four different messages in five gettext
items, two here and three here.
This being said, I am not disputing that the message rotation may not be an established design pattern and its effectiveness may not be known.
Highlighting the message visually with an animation as you propose may indeed be more effective. I have never worked with CSS animations but I will research it out and try to come up with a proposal.
I'm going to close this proposed solution as it's IMO too complicated for what we're trying to do here (give clear information that additional messages/files have been received), feel free to reopen if you disagree, but otherwise I think we should consider alternatives.
Description
Create a series of "rotating" confirmation pages in the Source UI, so that users always receive feedback affirming a new file upload or message submission.
User Impact
In today's Source UI, the confirmation message a Source receives after uploading a file or sending a message is like all messages—not the standard Javascript thing with dynamic info to speak to a user's specific actions, but a static bit of vague text. Which for single-action submissions, is fine.
For multi-action submissions in the same session, however (multiple files, a file followed by a message, a message followed by a file, multiple messages, etc.), the user receives no continued feedback. Freddy Martinez brought light to this crummy experience in a comment, in an older Issue. This issue, is a design solution to rectify that.
Considerations:
User Stories
As a Source making successive submissions in a single sit-down with a SecureDrop instance, I'd like to know a newsroom got my stuff ok.