freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!
https://securedrop.org/
Other
3.6k stars 686 forks source link

make dev stuck at the beginning on Debian Buster #4972

Closed kushaldas closed 4 years ago

kushaldas commented 4 years ago

Description

make dev is stuck at the beginning without much helpful text.

$ git log -1
commit 39fbc68a69c9d92c94de6431de1d30149dcc8280 (HEAD -> develop, origin/develop, origin/HEAD)
Merge: 486853c64 98838d91e
Author: redshiftzero <jen@freedom.press>
Date:   Tue Nov 5 10:33:27 2019 -0500

    Merge pull request #4968 from freedomofpress/docs-client-setup

    Link client developement documentation to the securedrop-client repository

Steps to Reproduce

make dev

Expected Behavior

The docker development environment is supposed to start.

Actual Behavior

Command output

kushaldas commented 4 years ago

I think some previous commit removed the output messages from the docker build command here.

kushaldas commented 4 years ago

Finally got the following error.

███ Starting development server...
The command '/bin/sh -c gpg --import /opt/tor_project_public.pub &&     wget  https://www.torproject.org/dist/torbrowser/${TBB_VERSION}/tor-browser-linux64-${TBB_VERSION}_en-US.tar.xz &&     wget https://www.torproject.org/dist/torbrowser/${TBB_VERSION}/tor-browser-linux64-${TBB_VERSION}_en-US.tar.xz.asc &&     gpg --verify tor-browser-linux64-${TBB_VERSION}_en-US.tar.xz.asc tor-browser-linux64-${TBB_VERSION}_en-US.tar.xz &&     tar -xvJf tor-browser-linux64-${TBB_VERSION}_en-US.tar.xz &&     mkdir -p /root/.local/tbb && mv tor-browser_en-US /root/.local/tbb &&    paxctl -cm /root/.local/tbb/tor-browser_en-US/Browser/firefox.real &&     paxctl -cm /root/.local/tbb/tor-browser_en-US/Browser/libnspr4.so &&     paxctl -cm /root/.local/tbb/tor-browser_en-US/Browser/plugin-container' returned a non-zero code: 8
make: *** [Makefile:183: dev] Error 8
kushaldas commented 4 years ago

I am guessing due to upgraded Tor browser, trying with latest version string.

kushaldas commented 4 years ago
███ Starting development server...
setsid: failed to execute supervisord: No such file or directory
redshiftzero commented 4 years ago

with latest Tor Browser from your PR in #4973 do you still hit supervisord: No such file or directory?

kushaldas commented 4 years ago

with latest Tor Browser from your PR in #4973 do you still hit supervisord: No such file or directory?

Yes, though I finally got the app running in the container (along with that error).

redshiftzero commented 4 years ago

what was the problem? or is the app running without supervisor?

kushaldas commented 4 years ago

what was the problem? or is the app running without supervisor?

I think it just did a rebuild of the docker image, and without any output, so I thought nothing is happening, I got the proper messages in my Unoon tool when it showed processes from inside of the container connecting to the network.

redshiftzero commented 4 years ago

ah okay, there are two problems we should address (we should address them because we'll have a lot of new people working on SD on saturday due to aaron swartz day):

  1. make dev doesn't produce build output by default, leading the contributor to be confused as to if things are happening or if the dev env is stalled
  2. we need to investigate the supervisord: No such file or directory error