"Delete Reply?" confirmation dialog needs... work. - Githubissues

freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!

https://securedrop.org/

Other

3.62k stars 688 forks source link

"Delete Reply?" confirmation dialog needs... work. #5152

Open ninavizz opened 4 years ago

ninavizz commented 4 years ago

Description

See dialog in lower-right of screenshot.

Steps to Reproduce

Delete a reply.

Expected Behavior

That it not look icky.

Actual Behavior

That it looks icky.

Comments

Zeplin forthcoming; but short of that it needs:

[ ] A dropshadow behind the box to enhance recognition of the window
[ ] A solid-primary button styling with the urgent coral, vs an outline button next to a link
[ ] Ohai even padding around all the edges
[ ] Preferred grimace=blue as the outline coloring for the dialog frame, but that's part of the TBD with the Zeplin.

TBH, I'd really prefer to just clean-up the Replies area, per this Zeplin... but that's a bigger project.

rocodes commented 4 years ago

Bumping for 1.3.0 QA visibility, relevant for testing https://github.com/freedomofpress/securedrop/pull/5096