search

freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!
https://securedrop.org/
Other
3.62k stars 685 forks source link

`securedrop-admin update` returns indistinguishable error messages for distinct error conditions #7200

Open cfm opened 2 months ago

cfm commented 2 months ago

Description

securedrop-admin update returns the same error message Signature verification failed. for multiple distinct error conditions. It's therefore necessary to step through the logic of the update() function to identify the cause of the error.

https://github.com/freedomofpress/securedrop/blob/f5ca29b6a279cc7d681ab6d7f08c98cedce2c8bd/admin/securedrop_admin/__init__.py#L1078-L1095

Steps to Reproduce

Discovered in the course of #7168.

Expected Behavior

Error messages either (a) are self-explanatory or (b) can be traced to a unique point in the code.

Actual Behavior

Neither.

Comments

It would be interesting to run a search for duplicated logging and exception strings across the codebase and see if this is a problem elsewhere.

xavierlwr commented 2 months ago

interested, will look into this

rudradeep22 commented 1 day ago

If no one is working on this, can I take this up?

legoktm commented 6 hours ago

Hey @rudradeep22, you're welcome to. If you have any questions or need help feel free to join our Matrix room.