generation of screenshots is broken

[cfm]

Description

The procedure for taking fresh screenshots via make translation-test is currently broken.

Steps to Reproduce

$ LOCALES=en_US make translation-test

Expected Behavior

Screenshots are taken.

Actual Behavior

After #6954, LOCALES=en_US is invalid, because en_US is not listed in i18n.json. That's easy enough to fix (though this needs testing):

--- a/securedrop/i18n.json
+++ b/securedrop/i18n.json
@@ -20,6 +20,10 @@
       "name": "Greek",
       "desktop": "el"
     },
+    "en_US": {
+      "name": "English",
+      "desktop": "en_US"
+    },
     "es_ES": {
       "name": "Spanish",
       "desktop": "es_ES"

But then make translation-test fails with:

FAILED tests/functional/pageslayout/test_submit_and_retrieve_file.py::TestSubmitAndRetrieveFile::test_submit_and_retrieve_happy_path[en_US] - selenium.common.exceptions.InvalidSessionIdException: Message: WebDriver session does not exist, or is not active

Comments

Since this is the only place this path is exercised, I thought a compound ticket would be fine. I'll bring the fix in a compound pull request with separate commits.