search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 25 forks source link

Add several reputable nonprofit news sources #106

Closed eloquence closed 7 years ago

conorsch commented 7 years ago

Thanks for the recommendations, @eloquence! We've been maintaining the list of sites via the admin GUI interface to the website, so the entries in the CSV are a bit out of date, but we're certainly not tracking the sites you propose. Will leave this open for more feedback from the team, and if we agree these sites should be added, we'll do so manually via the GUI.

eloquence commented 7 years ago

Sounds good, thanks! A bit more info about each source:

garrettr commented 7 years ago

This was accidentally added (and then reverted) as part of #109. I can't figure out how to re-open this pull request, but as @conorsch pointed out earlier, news_sites.csv is actually not the canonical list of sites being tracked by Secure the News - that list is stored in the production database and maintained through the CMS.

There is a reasonable argument to be made that we should maintain the list of sites being tracked in a text file in the repository, for transparency's sake, but that's not how we're managing it right now.

I'm consulting with the rest of the team right now, but I think it's likely that we'll add all of the sites you suggested to Secure the News because they are all reasonable additions. Cheers!

conorsch commented 7 years ago

I'm consulting with the rest of the team right now, but I think it's likely that we'll add all of the sites you suggested to Secure the News because they are all reasonable additions.

@garrettr @eloquence Confirmed: I'm in favor of adding all the sites in this PR to the site.

There is a reasonable argument to be made that we should maintain the list of sites being tracked in a text file in the repository, for transparency's sake, but that's not how we're managing it right now.

Let's add them manually for now and consider exporting to CSV periodically. Will open a separate issue for the CSV update tracking.

garrettr commented 7 years ago

Will open a separate issue for the CSV update tracking.

:+1: Alternatively, we could consider adding a management command that would auto-update the set of sites being tracked based on the contents of a CSV file. We already have most of the necessary code to do this in the loadsites.py management command, although we should give that a review and add some tests to make sure it handles deletions properly.

eloquence commented 7 years ago

That (automatic sync) would be nice. I'd be happy to help maintain the list either way, but I understand if doing this via PR is easier and has fewer security implications than adding users to the web frontend -- and it's generally a more understandable workflow for volunteers, anyway.

I can look into the loadsites.py code later this week if you don't have time to do it.

garrettr commented 7 years ago

Totally agree. I don't think there are any security concerns because we maintain control over merging contributions and pushing them into production. Frankly, maintaining the site list via CSV rather than through the Wagtail CMS would probably be a nicer workflow for us too 😁.

Let's wait for @conorsch to file an issue to track this and then we can dig into a bit more.