Closed msheiny closed 6 years ago
@harrislapiroff READY FOR RE-REVIEW. Got b82a16d
passing CI and the last commit was just a set of documentation changes soooo i dont expect it to fail but it takes like 25 min :|
Solid progress here. There are a few outstanding issues in the changes presented that block merge. To wit:
set -e
Once those concerns are addressed, we should be good to go.
See CI build failure demonstrating the problems with version-locking the apt dependencies:
ERROR: unsatisfiable constraints:
curl-7.60.0-r0:
breaks: world[curl=7.59.0-r0]
ERROR: Service 'django' failed to build: The command '/bin/sh -c apk add --no-cache
Let's rip that out.
CI has been running for an hour on https://circleci.com/gh/freedomofpress/securethenews/129 :grimacing: We're likely gonna have to tighten up the caching a bit here. While working on this PR, noticed that make dev-go
doesn't make use of the cache frequently—so there's some finetuning yet to do.
CI has been running for an hour on https://circleci.com/gh/freedomofpress/securethenews/129 grimacing We're likely gonna have to tighten up the caching a bit here.
So this ended up waiting for 5 hours. This wasnt a caching issue... django fell over. This was why the wait-for-it.sh script was introduced. So django will wait for postgres before starting up. So you took that script out and now the logic replaced with isnt working :( Its kewl tho! we can either fix that OR we can try to add that logic into Django itself.... @harrislapiroff do you know if there is a postgres retry setting?
Wait for environemnt to come up completely
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Step was canceled
Great fixes, @msheiny! Thanks for cleaning up my dust piles with the wait-for-it/nc changes. Quite pleased with the progress here. Surely we'll find additional touch-ups while working on the staging integration, but for now we've got a solid foundation to get rolling!
Things left to do: