Remove all traces of pledge feature in the codebase

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations

https://securethe.news

GNU Affero General Public License v3.0

100 stars 25 forks source link

Remove all traces of pledge feature in the codebase #163

Closed eloquence closed 4 years ago

eloquence commented 6 years ago

Resolves #162

Performed the following tests locally:

[X] Dev tests pass
[X] Prod tests pass
[X] Ops tests pass
[X] Perusing dev environment (incl. admin backend and API) reveals no trace of pledge feature, and layout of leaderboards and pages is correct

This does not add a migration, since the entire pledges app is removed via this PR. One way to remove its traces from the database is via manage.py pledges zero before applying this PR.

eloquence commented 5 years ago

Let's consider this once #143 is in; would be nice to no longer advertise the "pledge" feature when we blog about the leaderboards feature, since we never implemented a workflow for managing pledges nor do we intend to.

SaptakS commented 4 years ago

Rebased and fixed the conflicts. Looks all good to me. I think it would be nice to do manage.py pledges zero while deploying to remove the unnecessary table, unless we have any historical data, that we would like to keep.