search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 25 forks source link

Upgrades Node version 6.11.0 -> 10.15.1 #179

Closed conorsch closed 5 years ago

conorsch commented 5 years ago

Bumps the nodejs version to a supported LTS. The actual deploy logic must be updated separately—first, let's validate no breakage to the best of our ability here.

For the most part, I've abstained from updating the node dependencies themselves, opting to bump only the parent nodejs/npm versions. The exception is to the jade dep; see commit messages for details there.

Testing

First, it's critical that you run docker-compose build (or docker-compose up --build) on this branch. otherwise, you'll still be using the old containers, even if you have this branch checked out! See output from docker-compose for reference:

WARNING: Image for service node was built because it did not already exist. To rebuild this image you must use docker-compose build or docker-compose up --build.

Fire up the dev env, interact with the local site manually, see if you can identify any breakage. Keep an eye on the dev console in particular.

Refs: https://github.com/freedomofpress/fpf-www-projects/issues/33

harrislapiroff commented 5 years ago

Copying over my comments from https://github.com/freedomofpress/securedrop.org/pull/598:

I actually noticed, again, that the optional deps do switch around when I run docker-compose up --build after deleting my node_modules file. However, it looks like this is a known issue in npm that might, if I understand this issue, be resolved in an upcoming version of npm. Given that, I'm happy to merge Node upgrade PRs and just bear it till then.