search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 25 forks source link

Get JSON logging working in containers #182

Closed msheiny closed 5 years ago

msheiny commented 5 years ago

Ready for merge!

Should be seeing json output in the developer docker-compose env

msheiny commented 5 years ago

Functionally this does what it says on the tin! Is it desirable to have JSON output in the dev console though? I'm open to it but it seems potentially harder to read

This is a valid complaint. I wanted to be able to quickly iterate and test the json logging as it would appear in prod. Unfortunately the prod container takes forever to make this kind of change since everything is baked in. Maybe we should always use the prod container and do some fancy volume mounting for dev to work around this .