search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
102 stars 25 forks source link

Upgrade testinfra #188

Closed chigby closed 5 years ago

chigby commented 5 years ago

This pull request upgrades our testinfra version as well as other dependencies in Pipfile.lock.

These changes were accomplished with the command pipenv lock.

The motivation for this change is that the testinfra hash changed upstream, so pipenv install was failing.

chigby commented 5 years ago

It's possible I'm confused about the many layers of python at work here, but my intention here is not to upgrade python. The pipfile change, I had hoped, would be to constrain the "wrapper environment" (good term, I think) to run the same version of python everywhere that it's being used, be it dev, CI, or production.

On my local machine, just by happenstance, it was running under 3.6 but on CI it's running under 3.5. If the production environment is different, I don't want to cause any problems there! Though I think in that case we should change the python version to match production everywhere.

harrislapiroff commented 5 years ago

I think you're right and I'm confused. I'm just gonna merge it!