In the process I've also extended our NodeDockerfile to allow
us to easily specify an NPM version as part of the
docker-compose file
Since we are still on a supported LTS track with Node 10.x, I
decided to conservatively upgrade to the latest version of Node
10.x rather than upgrade to the absolutely latest Node (or even
the latest LTS track, which is node 12.x)
I also updated our NodeDockerfile to use CMD rather than
ENTRYPOINT to run webpack. This is more consistent with how
those declarations are intended:
Typically entrypoints accept a command and run some
environment logic before passing the command along
This allows the command to be overridden by e.g. docker run <cmd>
docker run <cmd>
Testing Instructions
Force a rebuild of the node container with
Confirm that
yields
v10.17.0
Confirm that
yields
6.13.4
After Merge
Every developer will need to force a rebuild of the node container for updates to be reflected in their dev environment: