search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
102 stars 25 forks source link

Upgrade django wagtail #218

Closed SaptakS closed 4 years ago

SaptakS commented 4 years ago

This pull request upgrades the site to Django 2.2 and Wagtail 2.7.

Fixes #217

chigby commented 4 years ago

I've checked over this PR again and I'm not seeing any menu-related errors in the admin.

I am still seeing the warnings, but I think it's okay to ignore them because: (1) they seem to be coming from within the wagtailmenus package, not our code. (2) the effect they describe, "There are no default tabs on non-Page models so there will be no Content tab for the content_panels to render in." Yet when editing a menu, there is indeed a content panel there. And a settings panel.

So, while possibly annoying, I think these warnings are not worth delaying our upgrade to wagtail 2.7 over.

harrislapiroff commented 4 years ago

Merging, per @chigby's approval!