Closed SaptakS closed 3 years ago
It looks like the problem with the autocomplete icon is that wagtailautocomplete
is overriding wagtail's built-in CSS, and sometime between 2.7 and 2.11, wagtail changed the specificity with which it styles the <input>
tags. It used to use the input
selector, and now it uses input:not([type="submit"])
. Or at least, this is my guess.
I was able to fix this locally by editing the CSS for the search box from wagtailautocomplete to have higher specificity, i.e. I changed
.c-wagtailautocomplete__search {
[...]
}
to
input.c-wagtailautocomplete__search {
[...]
}
But in order to fix this for real, we will want to incorporate something like this into wagtailautocomplete directly and release a new version.
I was able to fix this locally by editing the CSS for the search box from wagtailautocomplete to have higher specificity, i.e. I changed
I was curious if we should fix in wagtail-autocomplete or here in repo for the time.
I've released a new version of wagtail-autocomplete 0.6.1
Should be ready for review again.
I made a terribly embarassing mistake in wagtail autocomplete PR, which caused some issues. So we will need to wait till https://github.com/wagtail/wagtail-autocomplete/pull/89/files is merged.
Should be ready for re-reviewing.
Resolves #310
The only thing I have noticed and I think it's a wagtail autocomplete thing is in the regions autocomplete field when I start typing, the search icon svg stays on top:![image](https://user-images.githubusercontent.com/9530293/110376187-e7e66900-8078-11eb-8de3-0810e6ea66ef.png)
cc @harrislapiroff