freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 29 forks source link

Update wagtail2.11.5 #317

Closed SaptakS closed 3 years ago

SaptakS commented 3 years ago

Resolves #310

The only thing I have noticed and I think it's a wagtail autocomplete thing is in the regions autocomplete field when I start typing, the search icon svg stays on top: image

cc @harrislapiroff

chigby commented 3 years ago

It looks like the problem with the autocomplete icon is that wagtailautocomplete is overriding wagtail's built-in CSS, and sometime between 2.7 and 2.11, wagtail changed the specificity with which it styles the <input> tags. It used to use the input selector, and now it uses input:not([type="submit"]). Or at least, this is my guess.

I was able to fix this locally by editing the CSS for the search box from wagtailautocomplete to have higher specificity, i.e. I changed

.c-wagtailautocomplete__search {
 [...]
}

to

input.c-wagtailautocomplete__search {
  [...]
}

But in order to fix this for real, we will want to incorporate something like this into wagtailautocomplete directly and release a new version.

SaptakS commented 3 years ago

I was able to fix this locally by editing the CSS for the search box from wagtailautocomplete to have higher specificity, i.e. I changed

I was curious if we should fix in wagtail-autocomplete or here in repo for the time.

harrislapiroff commented 3 years ago

I've released a new version of wagtail-autocomplete 0.6.1

SaptakS commented 3 years ago

Should be ready for review again.

SaptakS commented 3 years ago

I made a terribly embarassing mistake in wagtail autocomplete PR, which caused some issues. So we will need to wait till https://github.com/wagtail/wagtail-autocomplete/pull/89/files is merged.

SaptakS commented 3 years ago

Should be ready for re-reviewing.