freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 29 forks source link

`null` in onion_location_header produces unexpected sort order #332

Closed thisisparker closed 3 years ago

thisisparker commented 3 years ago

If you sort descending by "Available Over Onion Services" on https://securethe.news/sites/, a handful of sites (currently ABC.es and the Washington Post) unexpectedly appear above the sites for which onion_location_header is true. This appears to be because the erroneous sites have a null in that field. I have not investigated nor know off-hand what circumstances produce a null value there.

null should probably not be an option, or if it is, it should not sort above true.

prateekj117 commented 3 years ago

@SaptakS @chigby I can have a look into it.

prateekj117 commented 3 years ago

@eloquence May I take this up?