search

freedomofpress / securethenews

An automated scanner and web dashboard for tracking TLS deployment across news organizations
https://securethe.news
GNU Affero General Public License v3.0
100 stars 25 forks source link

Fix downgrades_https None issue #77

Closed garrettr closed 7 years ago

garrettr commented 7 years ago

Pins the latest upstream version of pshtt, which includes my fix for the case where downgrades_https is None when it should be False.

Also includes a data migration to update historical values in the database to be consistent with values from the fixed crawler going forward.

garrettr commented 7 years ago

@conorsch @msheiny You will need to make the equivalent change from cb7c3e3 in the infrastructure repo so the production site will use the fixed version of pshtt.

Note: this is a great example of why I prefer to keep production configuration within the same repo as much as possible.

conorsch commented 7 years ago

You will need to make the equivalent change from cb7c3e3 in the infrastructure repo

:ok_hand: If that module were included as part of the normal site requirements, it'd be automatic. Thanks for calling attention to it, will make sure it gets updated.

garrettr commented 7 years ago

If that module were included as part of the normal site requirements, it'd be automatic.

@conorsch Yeah, I know! :sob: It's a bummer that pshtt has to be separate because it is stuck on Python 2. I've been agitating to improve that situation in my copious free time: https://github.com/dhs-ncats/pshtt/issues/4.

msheiny commented 7 years ago

kkk im going to try and deploy this now before i merge. tested locally fine though.

msheiny commented 7 years ago

DAPLOYED :boom: