search

freedomofpress / sunder

Sunder is a user-friendly graphical interface for Shamir's Secret Sharing.
https://sunder.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
160 stars 13 forks source link

Support saving MIME types in shares #26

Open GabeIsman opened 7 years ago

GabeIsman commented 7 years ago

This is a feature that @FredericJacobs has already added to rusty-secrets but isn't yet supported in the app. Shouldn't be too difficult, but I also don't think it should block launch.

garrettr commented 7 years ago

@GabeIsman Do you need anything from @FredericJacobs to implement this? I agree this would be a nice feature to have, but I don't think it's critical for 1.0.

FredericJacobs commented 7 years ago

We already have support for this in RustySecrets so I don't think so.

GabeIsman commented 7 years ago

Yup! As I noted above, this ready for UI implementation.

liliakai commented 6 years ago

I have this implemented in a branch, but it's blocked on #141 which simplifies the file input component somewhat.

One question I have is what to do with the mime type on the recover/export side. One obvious feature would be to infer the file extension when saving the recovered secret file to disk.

We could also consider rendering the file since electron/chrome is pretty good at displaying images, pdfs, html documents, etc.., given a mime type, but since that is tantamount to embedding remote content, we would need to be very careful to mitigate against malicious inputs.