A decent 404 page #271

[hyperkang]

https://github.com/freedomsponsors/www.freedomsponsors.org/issues/271

duplicated from template feedback.html - but skip listing reported issues

[tonylampada]

Can one of the admins verify this patch?

[tonylampada]

add to whitelist

[tonylampada]

Test PASSed. Refer to this link for build results: http://jenkins.freedomsponsors.org/job/FreedomSponsors/168/

[tonylampada]

Thanks! Showing the feedback form is a good idea! Haven't thought about that!

But this duplicates code with feedback. Html, which is bad.

This is easily solvable using an {℅ include ℅} Can you fix it? Maybe then use silencing similar on 500.html too!

[hyperkang]

Sure. I will fix it.

Regards, Kang

On Tue, May 20, 2014 at 8:28 PM, tonylampada notifications@github.comwrote:

Thanks! Showing the feedback form is a good idea! Haven't thought about that!

But this duplicates code with feedback. Html, which is bad.

This is easily solvable using an {℅ include ℅} Can you fix it? Maybe then use silencing similar on 500.html too!

— Reply to this email directly or view it on GitHubhttps://github.com/freedomsponsors/www.freedomsponsors.org/pull/272#issuecomment-43618734 .

[hyperkang]

Hi Tony,

I am going to extract the feedback form into a separated .html template file, and let both feedback.html and 404.html include it. Is this what you suggested? Can you explain a bit what you mentioned about 500.html? Shall we improve 500.html to be similar as 404.html?

Thanks, Kang

On Tue, May 20, 2014 at 8:28 PM, tonylampada notifications@github.comwrote:

Thanks! Showing the feedback form is a good idea! Haven't thought about that!

But this duplicates code with feedback. Html, which is bad.

This is easily solvable using an {℅ include ℅} Can you fix it? Maybe then use silencing similar on 500.html too!

— Reply to this email directly or view it on GitHubhttps://github.com/freedomsponsors/www.freedomsponsors.org/pull/272#issuecomment-43618734 .

[tonylampada]

Yes and yes :)

You can test the 500 page on a url like

https://freedomsponsors.org/core/issue/edit/submit

[tonylampada]

Test PASSed. Refer to this link for build results: http://jenkins.freedomsponsors.org/job/FreedomSponsors/169/

[hyperkang]

Hi Tony,

I updated the pull request, which includes following changes:

1. extract the feedback form to be included by other templates;
2. improve 500.html following the same way as 404.html.

https://github.com/freedomsponsors/www.freedomsponsors.org/pull/272

Regards, Kang

On Thu, May 22, 2014 at 11:03 PM, tonylampada notifications@github.comwrote:

Test PASSed. Refer to this link for build results: http://jenkins.freedomsponsors.org/job/FreedomSponsors/169/

— Reply to this email directly or view it on GitHubhttps://github.com/freedomsponsors/www.freedomsponsors.org/pull/272#issuecomment-43900175 .

[tonylampada]

Awesome, will test it later today, thanks!

[tonylampada]

Merged and deployed. Thanks!