search

freeipa / ansible-freeipa

Ansible roles and modules for FreeIPA
GNU General Public License v3.0
480 stars 231 forks source link

If an subtree is given convert it to an proper DN object. #1258

Closed arjanoosting closed 1 week ago

arjanoosting commented 2 weeks ago

This fixes the changed detection when an subtree option is supplied. (Fixes #1257)

t-woerner commented 2 weeks ago

@arjanoosting Thank you for the issue and this PR.

Your proposed change is working, but I discovered that there are more DN parameters that have the same issue. For ansible-freeipa we are converting the result from the show or find command to a string to fix the comparison of the parameters to only have string parameters in the modules. We also need a test for these parameters.

t-woerner commented 2 weeks ago

As we are close to a new release and to get the complete change in I created a new PR with fixes for all DN parameters and also added idempotency tests: #1259

Please give it a try.

rjeffman commented 1 week ago

Thank you for finding the issue and proposing a solution. I'm merging #1259 so we have a new release and closing this PR.