search

freeipa / freeipa-letsencrypt

A quick hack allowing to use Let's Encrypt certificates for FreeIPA web interface.
140 stars 71 forks source link

Update setup-le.sh #30

Closed afrothundaaaa closed 3 years ago

afrothundaaaa commented 3 years ago

Added Dynamic hostname creation and Dynamic LetsEncrypt CA Cert Download & Import Added script from community to fix static CA certs in this repo.

rcritten commented 3 years ago

And in reverse order, thanks for the contribution! A few minor comments.

rcritten commented 3 years ago

Not to be pedantic and slow things down but it would be clearer in git history if all of the changes to setup-le.sh we contained within the first patch (Update setup-le.sh to dynamically retrieve LE CA chain) and the second contained only the removal of the git-provided certificates.

afrothundaaaa commented 3 years ago

Not to be pedantic and slow things down but it would be clearer in git history if all of the changes to setup-le.sh we contained within the first patch (Update setup-le.sh to dynamically retrieve LE CA chain) and the second contained only the removal of the git-provided certificates.

Ok. I wasn't sure why this wasn't committed, but then i saw I had messed up the rebase. I have fixed it now and it should be showing properly. Sorry about that.

rcritten commented 3 years ago

Thanks, merging.