search

freeipa / freeipa-letsencrypt

A quick hack allowing to use Let's Encrypt certificates for FreeIPA web interface.
140 stars 71 forks source link

Fix frequent ssl renewals #47

Closed tilosp closed 9 months ago

tilosp commented 9 months ago

Before, the script renewed the cert as soon as it was older than two days. This lead to many unnecessary renewals. Now it only renews if it expires in less than 30 days (same as certbot).

Fixes https://github.com/freeipa/freeipa-letsencrypt/issues/46

rcritten commented 9 months ago

Thanks for the patch.

Can you add more information into the commit message as to what this fixes? It doesn't need to be a book. A line or two is find. Can you add signed-off-by (git commit -s) as well?

rcritten commented 9 months ago

The changes look good, thanks.