freeipa / freeipa-openshift-container

FreeIPA container for OpenShift 4
5 stars 7 forks source link

build: add trailing newline when patching Dockerfile #12

Closed frasertweedale closed 4 years ago

frasertweedale commented 4 years ago

When check-container-build-with-prci.sh patches the Dockerfile, it does not append a trailing newline to the new COPY line. If there is an empty line following the FROM directive, this is fine. But otherwise, it breaks the Dockerfile.

Append a trailing newline so that adjacent lines do not get joined by accident.

avisiedo commented 4 years ago

LGTM

frasertweedale commented 4 years ago

Thanks @avisiedo.