Store password in a Secret object

freeipa / freeipa-operator

EXPERIMENTAL kubernetes operator for FreeIPA

31 stars 5 forks source link

Store password in a Secret object #29

Closed avisiedo closed 3 years ago

avisiedo commented 3 years ago

Store password in a Secret object:

Avoid default passwords.
Provide passwords in a secure way by using secrets in the cluster.
Add a secret reference to the CRD, so that the secret can be referenced.
Add some unit tests.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avisiedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/freeipa/freeipa-operator/blob/master/OWNERS)~~ [avisiedo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

avisiedo commented 3 years ago

I set the PR in WIP for fixing the test failure.

avisiedo commented 3 years ago

I set the PR on WIP to implement some unit tests.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avisiedo, vashirov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/freeipa/freeipa-operator/blob/master/OWNERS)~~ [avisiedo,vashirov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 3 years ago

New changes are detected. LGTM label has been removed.