controller: Retrieve the baseDomain

freeipa / freeipa-operator

EXPERIMENTAL kubernetes operator for FreeIPA

31 stars 5 forks source link

controller: Retrieve the baseDomain #32

Closed avisiedo closed 3 years ago

avisiedo commented 3 years ago

controller: Retrieve the baseDomain

Restore the initial solution discussed along the PR as the merged one was failing for the permanent cluster.
Rename the method GetClusterDomain to InitBaseDomain, and update return to just return the error if any.
Improve documentation for the involved methods.

signed-off: Alejandro Visiedo avisiedo@redhat.com

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avisiedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/freeipa/freeipa-operator/blob/master/OWNERS)~~ [avisiedo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

frasertweedale commented 3 years ago

Thanks for the update. All makes sense.