search

freeipa / freeipa-operator

EXPERIMENTAL kubernetes operator for FreeIPA
31 stars 5 forks source link

config: Remove hostPath items from the configurations #36

Closed avisiedo closed 3 years ago

avisiedo commented 3 years ago

Rebase this when PR #35 is merged

Signed-off-by: Alejandro Visiedo avisiedo@redhat.com

vashirov commented 3 years ago

Same here, I see contents of #34 and #35 in this PR. Is it possible to split? Thanks.

avisiedo commented 3 years ago

Same here, I see contents of #34 and #35 in this PR. Is it possible to split? Thanks.

thanks @vashirov . this depends on #35 as it removes hostPath for statefulset object too; I start to update the #34

vashirov commented 3 years ago

The difference from #35 is three commits that remove configurations. Maybe you can modify #35 in the first place to not introduce them?

vashirov commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avisiedo, vashirov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/freeipa/freeipa-operator/blob/master/OWNERS)~~ [avisiedo,vashirov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment