freeipa / freeipa-operator

EXPERIMENTAL kubernetes operator for FreeIPA
31 stars 5 forks source link

Add 'host' field to the custom resource #51

Closed avisiedo closed 2 years ago

avisiedo commented 2 years ago

As an administrator I want to set the host from the custom resource that meet with:

frasertweedale commented 2 years ago

I'm not sure if this is the right thing to do. An IDM CR would be for a whole deployment, probably consisting of multiple servers. If it helps with any kind of demo situation right now, then I'm OK to merge it. Just wanted to point out that it's almost certainly going to have to change again.

Alternatively, we could auto-generate the server names for each replica, using the realm or IDM domain as the DNS suffix.

frasertweedale commented 2 years ago

@avisiedo pointed out that this PR also adds validation to ensure hostname does not exceed 64 chars. This is useful right now, so we can merge this PR. And later we will have to change it to allow specifying a "base domain" in the CR, and create IDM server domain names (for individual replicas) as children of that domain.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avisiedo, frasertweedale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/freeipa/freeipa-operator/blob/master/OWNERS)~~ [avisiedo,frasertweedale] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment