freeipa / freeipa-pr-ci

FreeIPA Pull Request CI
GNU General Public License v3.0
8 stars 32 forks source link

Responsibility for package installation #413

Open stanislavlevin opened 3 years ago

stanislavlevin commented 3 years ago

For now, pr-ci unconditionally installs all the IPA packages:

dnf install -y /vagrant/rpms/*.rpm

This is the simplest way, yes. But it has several disadvantages, such as:

The problem is that RPM(install+uninstall) != initial state. For example, https://github.com/freeipa/freeipa/pull/5376

I propose to move IPA RPMs installation responsibility to ipatests:

flo-renaud commented 3 years ago

See also freeipa #7525: [CI] Client installations are performed with server packages installed

As all the packages are installed (even the server packages on a client machine), we fail to detect packaging issues. Installing only the packages required by the machine role would definitely help.