search

freeipa / freeipa-webui

FreeIPA Web UI
GNU General Public License v3.0
23 stars 11 forks source link

Member - fix issues with indirect/direct member tab counts #532

Closed mreynolds389 closed 1 month ago

mreynolds389 commented 1 month ago

Also updated the member table to handle more membership types

Fixes: https://github.com/freeipa/freeipa-webui/issues/531

mreynolds389 commented 1 month ago

Before diving into the code, I have detected some issues in the UI that might be (or not) related to this PR:

  • 'User groups' > 'Is a member of' > 'Sudo rules':

    • Not reflecting the right number of sudo rules added (Direct)
    • When moving out from the tab section and coming back in, the elements dissapear (e.g., from Is a member of section to Members and back to Is a member of)

  • Active users > Is a member of > Roles

    • When deleting roles the items to delete on table don't match with the ones selected

  • Active users > Is a member of > any tab section

    • If any Direct elements on table, moving to Indirect and clicking Refresh button will update the tab count number with the elements from Direct

I'll look into this tomorrow (on PTO today), but I also suspect the memberOf pages behave the same way as this uses the same code approach. Anyway I'll fix it tomorrow...

mreynolds389 commented 1 month ago

Before diving into the code, I have detected some issues in the UI that might be (or not) related to this PR:

  • 'User groups' > 'Is a member of' > 'Sudo rules':

    • Not reflecting the right number of sudo rules added (Direct)
    • When moving out from the tab section and coming back in, the elements dissapear (e.g., from Is a member of section to Members and back to Is a member of)

  • Active users > Is a member of > Roles

    • When deleting roles the items to delete on table don't match with the ones selected

  • Active users > Is a member of > any tab section

    • If any Direct elements on table, moving to Indirect and clicking Refresh button will update the tab count number with the elements from Direct

I'll look into this tomorrow (on PTO today), but I also suspect the memberOf pages behave the same way as this uses the same code approach. Anyway I'll fix it tomorrow...

Well you pointed out issues with the MemberOf tab, but this was for Members :-) Anyway some of the issues you found did impact the Members tab (which are now fixed). Please review, once we merge this I will investigate the MemberOf issues you found.