search

freeipa / freeipa-webui

FreeIPA Web UI
GNU General Public License v3.0
23 stars 11 forks source link

Implement Hostgroup members #542

Closed mreynolds389 closed 3 weeks ago

mreynolds389 commented 4 weeks ago

Implement Hostgroup member tabs

Implement host/hostgroup member tabs for Host groups

Fixes: https://github.com/freeipa/freeipa-webui/issues/543

mreynolds389 commented 4 weeks ago

Apart from what's described in the comments below, the 'Add' and 'Delete' functionality in the Hosts section works fine. There is an issue that is affecting the Host groups section though: there is no restriction when trying to add the same host group from which the member is part of (and it is being shown in the 'Add' modal as an option). Of course this can be fixed in a different PR as part of an RFE.

No I'll fix this now. It probably impacts the UserGroups members as well.

mreynolds389 commented 4 weeks ago

Apart from what's described in the comments below, the 'Add' and 'Delete' functionality in the Hosts section works fine. There is an issue that is affecting the Host groups section though: there is no restriction when trying to add the same host group from which the member is part of (and it is being shown in the 'Add' modal as an option). Of course this can be fixed in a different PR as part of an RFE.

No I'll fix this now. It probably impacts the UserGroups members as well.

Fixed, simple one line change to filter it out. Delete button has also been fixed. Please review once more :-)

mreynolds389 commented 4 weeks ago

Added userGroup/hostGroup tests....