search

freelancewebdev / fbLogin

Facebook Login for MODX Revolution (2.2+)
http://www.hyper-typer.com/news/facebook-login-modx
4 stars 0 forks source link

Installation & system settings #1

Closed rtripault closed 12 years ago

rtripault commented 12 years ago

Please, consider creating all system settings with empty values if information are not filled during the setup, so we can manually edit them later.

freelancewebdev commented 12 years ago

That's what happens Romain - I haven't put any validation in the setup options to check they are completed. I guess the 'all fields are required' message is a bit misleading when you look at it that way but I need to communicate that the extra won't work without all settings being set - definitely will look at that for the 'pl' release :)

rtripault commented 12 years ago

Well, https://github.com/freelancewebdev/fbLogin/blob/master/_build/resolvers/setupoptions.resolver.php#L136 makes me believe it's not the case ;)

I've upgraded from RC1 (with no system settings created), so checking against them should have always returned null. I guess, instead of logging the errors, creating the settings with empty values might be an option.

Anyway, thanks for your reply & your work!

freelancewebdev commented 12 years ago

Ah, that makes sense - didn't realise you were upgrading. Definitely in 'pl'. Curious to see how it goes in deployment for people - will give it a week or two for feedback before I move the code on.

rtripault commented 12 years ago

Well, i forgot to state that was an upgrade, sorry.

I have not really played with your work (just cross read your previous release), but will definitely report how it went :)

While i'm here (not sure if i should state this here or open another issue), may i suggest not to create resources (or at least provide an option to allow/disable the default resources creation) ?

freelancewebdev commented 12 years ago

Yeah, will do that. Apart from anything else though its pretty unlikely given the aliases, there may be cases where there are name collisions. Think its kinda handy for many though not to have to deal with that at all so will make it an option rather than the default.

Kind regards,

Joe Molloy

F R E E L A N C E  W E B  D E V E L O P E R

C O N T A C T  D E T A I L S

Mobile:                  +353 86 6087493 Landline:                +353 1 8348780 Web:                      hyper-typer.com

C o n n e c t i o n s

Twitter:                   twitter.com/FreelaneWebDev Facebook:               fb.me/FreelanceWebDeveloperIreland Google Plus:           gplus.to/FreelanceWebDev Skype:                    FreelanceWebDev

RSS:                      hyper-typer.com/latestnews.rss

On 29 February 2012 00:20, Romain reply@reply.github.com wrote:

Well, i forgot to state that was an upgrade, sorry.

I have not really played with your work (just cross read your previous release), but will definitely report how it went :)

While i'm here (not sure if i should state this here or open another issue), may i suggest not to create resources (or at least provide an option to allow/disable the default resources creation) ?

Reply to this email directly or view it on GitHub: https://github.com/freelancewebdev/fbLogin/issues/1#issuecomment-4229083