search

freelancewebdev / fbLogin

Facebook Login for MODX Revolution (2.2+)
http://www.hyper-typer.com/news/facebook-login-modx
4 stars 0 forks source link

firstloginResourceId doesnt work #8

Open marcushouse opened 10 years ago

marcushouse commented 10 years ago

Doesn't seem to work for me. Your snippet.fbLogin.php file contains things like $fristloginResourceId which is not actually used anywhere. tried fixing that up but it doesnt seem to redirect on fist sign up. Must be a double redirection or some such issue. Not sure.

freelancewebdev commented 10 years ago

Hi Marcus,

Sorry to hear you are having issues with the addon.

Unfortunately I don't have the time to look into this issue at the moment - Christmas rush and all.

it looks like inadvertently introduced some problems in 1.4. That '$fristloginResourceId' variable you refer to should be '$firstloginResourceId' - it is basically the resource your user is taken to the first time they log in with the Facebook credentials and it is saved as a system setting - if specified when you are setting up the addon, it gives you a chance to redirect the user to get extra profile info from them above and beyond that which is retrieved from Facebook.

Regards,

Joe

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev

RSS: hyper-typer.com/latestnews.rss

On 9 December 2013 11:52, marcushouse notifications@github.com wrote:

Doesn't seem to work for me. Your snippet.fbLogin.php file contains things like $fristloginResourceId which is not actually used anywhere. tried fixing that up but it doesnt seem to redirect on fist sign up. Must be a double redirection or some such issue. Not sure.

? Reply to this email directly or view it on GitHubhttps://github.com/freelancewebdev/fbLogin/issues/8 .

marcushouse commented 10 years ago

Thanx joe. I know the feeling. I maintain formitbuiler for modx. Would be nice to make paid addons wouldnt it. :)

That way we would be more inclined to maintain them better.

I solved the problem outside in a round about way. Thanx for the reply. On 10/12/2013 12:18 AM, "Joe Molloy" notifications@github.com wrote:

Hi Marcus,

Sorry to hear you are having issues with the addon.

Unfortunately I don't have the time to look into this issue at the moment

Christmas rush and all.

it looks like inadvertently introduced some problems in 1.4. That '$fristloginResourceId' variable you refer to should be '$firstloginResourceId' - it is basically the resource your user is taken to the first time they log in with the Facebook credentials and it is saved as a system setting - if specified when you are setting up the addon, it gives you a chance to redirect the user to get extra profile info from them above and beyond that which is retrieved from Facebook.

Regards,

Joe

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev

RSS: hyper-typer.com/latestnews.rss

On 9 December 2013 11:52, marcushouse notifications@github.com wrote:

Doesn't seem to work for me. Your snippet.fbLogin.php file contains things like $fristloginResourceId which is not actually used anywhere. tried fixing that up but it doesnt seem to redirect on fist sign up. Must be a double redirection or some such issue. Not sure.

? Reply to this email directly or view it on GitHub< https://github.com/freelancewebdev/fbLogin/issues/8> .

— Reply to this email directly or view it on GitHubhttps://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30130968 .

freelancewebdev commented 10 years ago

Marcus,

Glad to hear you found a solution and nice work on formitbuilder. I certainly don't think the average MODX user knows just how much work goes into producing even the simplest addon by the time you've done the docs, lexicon translations and packaging.

I know fbLogin is in a bit of a mess at the moment - It was my first addon and I honestly didn't have much of a clue about what I was doing on the MODX end even though I had quite a bit of experience working with the Facebook API. I'm torn between withdrawing it or fixing it - there really isn't much wrong with it - I do have it working in production sites. I think though it has little use for folk unless they are going to do something substantial with the info they can pull in from Facebook and that takes a level of expertise that would mean they wouldn't really need the addon in the first place - its really only a time saver in that case.

I was migrating my dev work from Linux to OSX the last time I updated the package and it suffered as a result. I will definitely do something about it, soon as I figure out what :)

In the meantime, if you have any other questions about it, let me know, I should be able to steer you along with it.

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev

RSS: hyper-typer.com/latestnews.rss

On 11 December 2013 12:18, marcushouse notifications@github.com wrote:

Thanx joe. I know the feeling. I maintain formitbuiler for modx. Would be nice to make paid addons wouldnt it. :)

That way we would be more inclined to maintain them better.

I solved the problem outside in a round about way. Thanx for the reply. On 10/12/2013 12:18 AM, "Joe Molloy" notifications@github.com wrote:

Hi Marcus,

Sorry to hear you are having issues with the addon.

Unfortunately I don't have the time to look into this issue at the

moment

Christmas rush and all.

it looks like inadvertently introduced some problems in 1.4. That '$fristloginResourceId' variable you refer to should be '$firstloginResourceId' - it is basically the resource your user is taken to the first time they log in with the Facebook credentials and it is saved as a system setting - if specified when you are setting up the addon, it gives you a chance to redirect the user to get extra profile info from them above and beyond that which is retrieved from Facebook.

Regards,

Joe

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev RSS: hyper-typer.com/latestnews.rss

On 9 December 2013 11:52, marcushouse notifications@github.com wrote:

Doesn't seem to work for me. Your snippet.fbLogin.php file contains things like $fristloginResourceId which is not actually used anywhere. tried fixing that up but it doesnt seem to redirect on fist sign up. Must be a double redirection or some such issue. Not sure.

? Reply to this email directly or view it on GitHub< https://github.com/freelancewebdev/fbLogin/issues/8> .

? Reply to this email directly or view it on GitHub< https://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30130968>

.

? Reply to this email directly or view it on GitHubhttps://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30315722 .

marcushouse commented 10 years ago

No worries mate. I'm using it in a little training website. Working good for me so far.

Nice work mate. Personally I think modx components are a pain to develop due to the build packaging. Hard to update and deploy. As you say. People dont understand the time and commitment.

I'd love to see a component do additional google and twitter connects as well... but the modx community hasnt really grown as i would like.

Take it easy! Thanx again. On 12/12/2013 3:49 AM, "Joe Molloy" notifications@github.com wrote:

Marcus,

Glad to hear you found a solution and nice work on formitbuilder. I certainly don't think the average MODX user knows just how much work goes into producing even the simplest addon by the time you've done the docs, lexicon translations and packaging.

I know fbLogin is in a bit of a mess at the moment - It was my first addon and I honestly didn't have much of a clue about what I was doing on the MODX end even though I had quite a bit of experience working with the Facebook API. I'm torn between withdrawing it or fixing it - there really isn't much wrong with it - I do have it working in production sites. I think though it has little use for folk unless they are going to do something substantial with the info they can pull in from Facebook and that takes a level of expertise that would mean they wouldn't really need the addon in the first place - its really only a time saver in that case.

I was migrating my dev work from Linux to OSX the last time I updated the package and it suffered as a result. I will definitely do something about it, soon as I figure out what :)

In the meantime, if you have any other questions about it, let me know, I should be able to steer you along with it.

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev

RSS: hyper-typer.com/latestnews.rss

On 11 December 2013 12:18, marcushouse notifications@github.com wrote:

Thanx joe. I know the feeling. I maintain formitbuiler for modx. Would be nice to make paid addons wouldnt it. :)

That way we would be more inclined to maintain them better.

I solved the problem outside in a round about way. Thanx for the reply. On 10/12/2013 12:18 AM, "Joe Molloy" notifications@github.com wrote:

Hi Marcus,

Sorry to hear you are having issues with the addon.

Unfortunately I don't have the time to look into this issue at the

moment

Christmas rush and all.

it looks like inadvertently introduced some problems in 1.4. That '$fristloginResourceId' variable you refer to should be '$firstloginResourceId' - it is basically the resource your user is taken to the first time they log in with the Facebook credentials and it is saved as a system setting - if specified when you are setting up the addon, it gives you a chance to redirect the user to get extra profile info from them above and beyond that which is retrieved from Facebook.

Regards,

Joe

Kind regards,

Joe Molloy

F R E E L A N C E W E B D E V E L O P E R

C O N T A C T D E T A I L S

Mobile: +353 86 6087493 Landline: +353 1 8348780 Web: hyper-typer.com

C o n n e c t i o n s

Twitter: twitter.com/FreelanceWebDev Facebook: fb.me/FreelanceWebDeveloperIreland Google Plus: gplus.to/FreelanceWebDev Skype: FreelanceWebDev RSS: hyper-typer.com/latestnews.rss

On 9 December 2013 11:52, marcushouse notifications@github.com wrote:

Doesn't seem to work for me. Your snippet.fbLogin.php file contains things like $fristloginResourceId which is not actually used anywhere. tried fixing that up but it doesnt seem to redirect on fist sign up. Must be a double redirection or some such issue. Not sure.

? Reply to this email directly or view it on GitHub< https://github.com/freelancewebdev/fbLogin/issues/8> .

? Reply to this email directly or view it on GitHub<

https://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30130968>

.

? Reply to this email directly or view it on GitHub< https://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30315722>

.

— Reply to this email directly or view it on GitHubhttps://github.com/freelancewebdev/fbLogin/issues/8#issuecomment-30338020 .

Brey1013 commented 9 years ago

marcushouse you mentioned that you had solved the problem in a round-about way. Would you mind sharing how you had done it? This is a pretty serious function that is no longer working.