freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.
https://www.courtlistener.com
Other
546 stars 151 forks source link

Smart quotes break search queries #2790

Open mlissner opened 1 year ago

mlissner commented 1 year ago

A user just complained that phrase search wasn't working. Why? Because they were using smart quotes. Silly of them, but it happens:

https://www.courtlistener.com/?type=r&q=%E2%80%9Cping%20tree%E2%80%9D%20leads&type=r&order_by=score%20desc

We should add this to the list of many things we clean up. There's no reason smart quotes shouldn't be replaced with dumb ones whenever they're in a query.

mlissner commented 1 year ago

This appears to be an iPhone thing, according to the user. I haven't noticed, but apparently it does smart quotes by default. Lame.

mlissner commented 2 months ago

Let's make sure unbalanced smart quotes throw errors or get fixed, as appropriate too.