freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.
https://www.courtlistener.com
Other
500 stars 137 forks source link

Move k8s variables to secrets manager #3622

Open mlissner opened 5 months ago

mlissner commented 5 months ago

I'm not sure how to do this, but we should figure it out so that our secrets are more secure.

blancoramiro commented 3 weeks ago

Just leaving an update here until we start moving the variables into AWS' secret manager.

External secrets operator is now deployed in the court-listener cluster. The documentation is located here

And here is the current configuration.

mlissner commented 3 weeks ago

Thanks for the great docs. Do you need changes on the application side?

blancoramiro commented 3 weeks ago

No changes to the app itself only to the k8s yaml files.

For the deployments to start using secrets from the secrets manager we would need to:

The only possible issue might be that if any pod get scheduled while the secret is not yet re-created, it won't be scheduled.

blancoramiro commented 3 days ago

@mlissner Found the following secrets set up in the cluster but they are missing in the repo.

Do you think they should be added to the new secret stored in the secrets manager?

Secrets present in cl-env but not on the repo:

Secrets present in bots-env but not on the repo:

Thank you!

mlissner commented 3 days ago

All of the variables in cl-env aren't important. They're outdated or typos.

All of the variables in bots-env are the opposite. They are important and need to be preserved.

Good catches.