freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.
https://www.courtlistener.com
Other
548 stars 150 forks source link

Move k8s variables to secrets manager #3622

Closed mlissner closed 4 months ago

mlissner commented 10 months ago

I'm not sure how to do this, but we should figure it out so that our secrets are more secure.

blancoramiro commented 5 months ago

Just leaving an update here until we start moving the variables into AWS' secret manager.

External secrets operator is now deployed in the court-listener cluster. The documentation is located here

And here is the current configuration.

mlissner commented 5 months ago

Thanks for the great docs. Do you need changes on the application side?

blancoramiro commented 5 months ago

No changes to the app itself only to the k8s yaml files.

For the deployments to start using secrets from the secrets manager we would need to:

The only possible issue might be that if any pod get scheduled while the secret is not yet re-created, it won't be scheduled.

blancoramiro commented 4 months ago

@mlissner Found the following secrets set up in the cluster but they are missing in the repo.

Do you think they should be added to the new secret stored in the secrets manager?

Secrets present in cl-env but not on the repo:

Secrets present in bots-env but not on the repo:

Thank you!

mlissner commented 4 months ago

All of the variables in cl-env aren't important. They're outdated or typos.

All of the variables in bots-env are the opposite. They are important and need to be preserved.

Good catches.

blancoramiro commented 4 months ago

Hello @mlissner . I think we are good to close this issue.

New secrets for Courtlistner and Bots.law have been in place for some time and no issues have been reported.

Documentation related to the external secrets operator and how secrets are now handled is here

Thank you!