feat(favorites): frontend revisions to pray and pay project

freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.

https://www.courtlistener.com

Other

552 stars 151 forks source link

feat(favorites): frontend revisions to pray and pay project #4580

Open v-anne opened 1 month ago

v-anne commented 1 month ago

This is the PR for making frontend changes to the pray and pay user interface.

Mike had some great comments in #4507, so we'll start with them and see what's needed once the low-hanging fruit is done.

Additions include:

Allowing users to request a document from the recap_document.html page.
Revamping UI of top_prayers.html to provide better UX.
Creating user_prayers.html page to allow users to see their open and fulfilled prayers, and also summary statistics about how many requests they've had fulfilled. In a future PR, this will be made similar to tags to allow people (e.g., freelance journalists) to share documents they've requested.
documentation for how pray and pay project works.
minor grammar changes to email notifications.

v-anne commented 1 month ago

@ERosendo this is the PR I'm going to build off of.

mlissner commented 1 month ago

Seeing some commit messages around the user-prayer page. Reminds me that it doesn't have to be available in the profile section, just like tags aren't. The user prayers page could just be linked from the mouseover for each emoji or from the most-wanted page, for example.

v-anne commented 1 month ago

Yeah, tags are what I am aiming to emulate.

v-anne commented 1 month ago

I'm having some issues getting the three buttons to display inline with each other in recap_document.html. Ideally, the prayer button would be to the right of the other two.

v-anne commented 1 month ago

Having same issue with the button on the modal. There's also a related issue where if I click the prayer button repeatedly, the count will increase despite having exhausted the quota.

I gather this is an issue with the CSS, but I tried making some changes and was unsuccessful.

mlissner commented 1 month ago

@ERosendo, do you think you could help, please?

ERosendo commented 1 month ago

@mlissner sure! 👍

v-anne commented 1 month ago

@ERosendo in addition to those two issues with the buttons, I've mostly finished a MVP of the user_prayers.html page.

This is what it currently looks like. The status column is broken; I can't figure out why the backend isn't passing the information through to the template. I intend to add a button to allow users to delete requests and one for them to download available documents as well.

v-anne commented 1 month ago

@mlissner @ERosendo I've finished up my end of this. I've highlighted some concerns of mine regarding bits that might merit closer scrutiny.

mlissner commented 1 month ago

Can you post a few more screenshots for me, @v-anne?

v-anne commented 1 month ago

mlissner commented 1 week ago

@v-anne, I noticed this PR is paused. Are you waiting for feedback or something else?

v-anne commented 1 week ago

Sorry @mlissner, I had stepped back because I thought @ERosendo was going to take a look at some of the issues I had raised with my code.

mlissner commented 1 week ago

Got it. We're moving to a sprint/scrum model, but I'll get this on his new list. :)

v-anne commented 1 week ago

Not related to these changes Mike, but I think there might be some issues with email. I'm not receiving alerts for every fulfilled request.

mlissner commented 1 week ago

Not related to these changes Mike, but I think there might be some issues with email. I'm not receiving alerts for every fulfilled request.

I checked your account and we've sent you 41 emails about pay-and-pray so far. If you want to debug a particular one, emails is probably the better way to go.