freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.
https://www.courtlistener.com
Other
550 stars 151 forks source link

feat(contact_form): Add more issue types to ContactForm #4648

Closed elisa-a-v closed 2 weeks ago

elisa-a-v commented 2 weeks ago

Addresses #4615

This PR adds more choices for issue types in the contact form so it now includes:

It also changes the label for support so it now says "General Support".

mlissner commented 2 weeks ago

Looks good to me, thank you!

mlissner commented 2 weeks ago

One small comment for you, @elisa-a-v. Please try to use the auto-closing tricks that Github has so that issues get automatically closed when PRs are merged:

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

E.g., if you had said "Fixes #4648" above, instead of "Addresses #4648", it would have auto-closed. Handy!

But nice little PR otherwise. Commit messages look good, code is clean. Nice stuff. I'm nitpicking because that's all I've got!

elisa-a-v commented 2 weeks ago

E.g., if you had said "Fixes #4648" above, instead of "Addresses #4648", it would have auto-closed. Handy!

omg I didn't know that, I love it! Of course I'll use those from now on 👌🏽

Thanks for the comments!

mlissner commented 2 weeks ago

You can put it in a commit too. It's a great little feature.