search

freelawproject / courtlistener

A fully-searchable and accessible archive of court data including growing repositories of opinions, oral arguments, judges, judicial financial records, and federal filings.
https://www.courtlistener.com
Other
550 stars 151 forks source link

Auto-merging - issue? #4720

Open flooie opened 13 hours ago

flooie commented 13 hours ago

https://github.com/freelawproject/courtlistener/pull/4719

I was bumping juriscraper and set the PR to auto merge if all requirements were met. The automerge completed and then a random unrelated recap test failed. I'm not sure if this is a bug but I was under the impression that all tests needed to pass for auto merge to merge.

mlissner commented 13 hours ago

Are you sure that you didn't just hit the merge button? I feel like auto-merge disappeared for me while tests are running.

There's a RECAP issue that Eduardo is working on in the tests.

flooie commented 13 hours ago

I guess that's as likely a scenario as there is. I was pretty sure I selected auto merge though.

mlissner commented 13 hours ago

Yeah, who knows. I don't know how/why automerge got changed. I haven't played with the branch protection settings, have you?