search

freelawproject / courts-db

A database of courts, tests and other experiments
BSD 2-Clause "Simplified" License
59 stars 16 forks source link

Add subset of CAP court names #17

Open 4ndygu opened 3 years ago

4ndygu commented 3 years ago

Hi there! I am currently mining some of the data in the Caselaw Access Project API, and we noticed that some of the Regex patterns in courts.json do not match the courts displayed in api.case.law/v1/courts/. This pull requests takes a subset of the most frequently seen courts in CAP and adds those court names to the Regex pattern of the underlying dataset.

4ndygu commented 3 years ago

Also tagging @jcushman for visibility.

mlissner commented 3 years ago

Thanks @4ndygu!

This looks OK to me at a skim, though tests seem to be failing.

@flooie will you give it a final review once tests are working?

4ndygu commented 3 years ago

Hi @mlissner! sorry for the late response, and my bad -- it seems like I may have included some of the regex patterns in the examples page, which polluted the tests. These should be updated now!

mlissner commented 3 years ago

This should be back to you, then, @flooie.

flooie commented 3 years ago

@4ndygu this looks great. Thank you for adding your two cents. I hope to give this a deeper look tomorrow.

flooie commented 3 years ago

@mlissner also if I remember correctly, we haven't completed regex patterns for every example permutation yet, so I don't think @4ndygu additions caused that test to fail.

4ndygu commented 3 years ago

Hi @flooie! Just to clarify, might be my bad here -- i think the error arose because I accidentally added two patterns to the examples section as opposed to regex, which would have caused the existing regex patterns at the time to fail.

flooie commented 3 years ago

That sounds like it would cause the fail for sure.

On Jul 12, 2021, at 5:39 PM, Andy Gu @.***> wrote:

 Hi @flooie! Just to clarify, might be my bad here -- i think the error arose because I accidentally added two patterns to the examples section as opposed to regex, which would have caused the existing regex patterns at the time to fail.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.