search

freelawproject / courts-db

A database of courts, tests and other experiments
BSD 2-Clause "Simplified" License
59 stars 16 forks source link

source package does not include data #33

Open step21 opened 3 years ago

step21 commented 3 years ago

While trying to make a conda package - I found out that the source package does not include the data, and thus cannot be used successfully. Ideally, I think the data (json files) should be included. At least in the source package I also did not find a way to generate this data. (such as courts_db/data/*.json)

step21 commented 3 years ago

according to this the package_data specified in setup.py only works for binary dists, whereas Manifest.in works for both.

mlissner commented 3 years ago

@flooie can you take a look at this? I just looked through all of the versions of courts-db that have ever been on PyPi and none of them include the actual court data. Seems like it's possible we never installed the package and nobody else did either? Maybe they did but gave up?

mlissner commented 3 years ago

See also: https://github.com/freelawproject/courts-db/pull/35

step21 commented 3 years ago

What is more likely in my opinion, they just installed the wheel (*.whl) which does seem to contain them. It is just a zip file with another extension. Most of the time there is no need for the source distribution because courts-db doesn't contain compiled files afaik, so they just used that.