search

freelawproject / courts-db

A database of courts, tests and other experiments
BSD 2-Clause "Simplified" License
57 stars 15 forks source link

Add [tool.poetry] section to pyproject.toml #63

Closed anseljh closed 1 year ago

anseljh commented 1 year ago

A dependent project was complaining about its absence, so I added it.

mlissner commented 1 year ago

That's a bit weird. What tool? We don't use Poetry for this project, I don't think?

anseljh commented 1 year ago

I'd added this project as a dependency for a new project based on the repo template, which does use Poetry, or at least I used Poetry in it. Adding this made its complaints go away. 🤷‍♂️

mlissner commented 1 year ago

Sorry, with packaging stuff I like to proceed pretty carefully. Do you have steps to reproduce for this or the error you saw?

If we add these tweaks, we'll have a setup.py file and a pyproject.toml file, both of which have the version number, which feels like an anti-pattern. (We also tag our git commits with the version, which makes it three places, not great!)

anseljh commented 1 year ago

All good concerns! I'll try to reproduce it in a new repo and will share that back here.

anseljh commented 1 year ago

Don't think we need this after all! Not sure where I messed up, but this seems to not be an issue if you're more careful than I was.

mlissner commented 1 year ago

Whew, good. I was not looking forward to getting the poetry maintainers to fix this!