freelawproject / doctor

A microservice for document conversion at scale
https://free.law/projects/doctor
BSD 2-Clause "Simplified" License
57 stars 15 forks source link

Docs are unclear, types are over-broad, cleanup needed #149

Closed mlissner closed 2 years ago

mlissner commented 2 years ago

Over in https://github.com/freelawproject/courtlistener/pull/2312/files#diff-6b97c7d7c910daaa051cf22884b960484e47ee033e28656eaa1cbd3aa885ed36L205, @albertisfu made a change from:

content = response.content

To:

content = response.text

That made me wonder if doctor returns utf-8-encoded text or something else. I dug in. The docs didn't say, the code wasn't clear, and I saw some commented out stuff that shouldn't be in our finished work.