build deploy pipeline breaks when merging prs

freelawproject / doctor

A microservice for document conversion at scale

https://free.law/projects/doctor

BSD 2-Clause "Simplified" License

54 stars 14 forks source link

build deploy pipeline breaks when merging prs #189

Closed trashhalo closed 4 months ago

trashhalo commented 4 months ago

Went to pull in new version after you merged #188 and noticed that the docker hub build hadn't been updated. When I check out the deploy action it seems to fail consistently on merge, missing the credentials needed to push to docker hub. https://github.com/freelawproject/doctor/actions/workflows/deploy.yml

Not sure if this is intentional but wanted to flag it.

mlissner commented 4 months ago

This is an annoying thing because you're not in our workspace, so your PRs don't have access to our docker secrets. We have another PR coming in shortly from a staff member, so when that comes in, we should get a good deployment. I'm going to close, but let's pick this up over Slack.