Closed grossir closed 2 months ago
Your pull request is modifying functions with the following pre-existing issues:
📄 File: doctor/tasks.py
Function | Unhandled Issue |
---|---|
set_mp3_meta_data |
OSError: file not found: /tmp/audio_ed1208396689465a9185e47376e5cfcf /... Event Count: 1 |
Did you find this useful? React with a 👍 or 👎
This looks great to me. Any reason it's still a draft?
@mlissner I noticed a discrepancy in the dimensions of the new logo compared to the old one. For consistency, let's make sure the new logo uses the same dimensions as the previous one. Additionally, the old logo had a white background, while the new one appears transparent.
Here's a file with the same dimensions (300x300) and a white background.
Great points, thanks!
I am using this logo converted from png to svg using
rsvg-convert
from packagelibrsvg2-bin
on UbuntuHow the audio file looks on Ubuntu file explorer, when there is both s, "Front Cover" and "Publisher logo" metadata
How it looks when there is only "Publisher logo" metadata
ffprobe output recognizes both images, "Front Cover" and "Publisher logo". See Stream #0:1 and Stream #0:2
As an aside, I tested using the svg image directly, with a mime type "image/svg", and my file explorer would recognize and render the image; however, ffprobe would tag it as invalid
Unknown attached picture mimetype: image/svg, skipping.
, which does not happen when using a png