search

freelawproject / eyecite

Find legal citations in any block of text
https://freelawproject.github.io/eyecite/
BSD 2-Clause "Simplified" License
123 stars 32 forks source link

Rename NonopinionCitation to UnknownCitation #109

Closed mattdahl closed 2 years ago

mattdahl commented 2 years ago

NonopinionCitation seems like a misnomer now that we have FullLawCitation and FullJournalCitation abstractions (which are obviously not opinions). The point of NonopinionCitation is to serve as a naive catch-all for any citation that can't be otherwise parsed, so I think it should be renamed to something like UnknownCitation.

mlissner commented 2 years ago

Makes sense. Ah to have a stable API. Someday!

mattdahl commented 2 years ago

Uh, so it seems like you agree, but you also closed this issue? Not sure how to interpret :)

mlissner commented 2 years ago

Oops, didn't mean to.

mattdahl commented 2 years ago

Fixed in #110