search

freelawproject / eyecite

Find legal citations in any block of text
https://freelawproject.github.io/eyecite/
BSD 2-Clause "Simplified" License
123 stars 32 forks source link

Rename NonopinionCitation to UnknownCitation #110

Closed mattdahl closed 2 years ago

mattdahl commented 2 years ago

Addresses #109.

mlissner commented 2 years ago

Is it worth it to do an alias here and emit a deprecation warning? We haven't done that in the past, but it'd be pretty easy to do, I think.

mattdahl commented 2 years ago

Interesting idea -- I'm not totally sure on the pattern here, but I just pushed a commit that takes a stab at that. I said it would be deprecated in 2.5.0 on the logic that the next release will be 2.4.0, so it should be removed in the release after that one?

mlissner commented 2 years ago

Thank you Matt!