search

freelawproject / eyecite

Find legal citations in any block of text
https://freelawproject.github.io/eyecite/
BSD 2-Clause "Simplified" License
118 stars 29 forks source link

test and fix for issue #167 #168

Closed cbrew closed 7 months ago

cbrew commented 7 months ago

Hash function did not handle datetime and failed.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

mlissner commented 7 months ago

Looks like we've got issues with our build unrelated to this PR. @cbrew, do I guess correctly that you'd rather not go down this rabbit hole? If so, I can ask somebody on our staff to do so, or it's possible @mattdahl might be game.

mattdahl commented 7 months ago

I never know how to debug any of these GH actions, unfortunately

mlissner commented 7 months ago

Fair enough. @cbrew, what do you think?

cbrew commented 7 months ago

I don’t think Lexis would thank me for spending the time. I was game if it was going to take only a little time. So if someone can take it, great.

I’m interested in finding out how far new tech can take us in delimiting the borders of the citing language, either with or without assumptions about which passage the citation is pointing to. The chance of having both ends of the graph edge visible in pile of law goes up fast as its coverage increases. Having your tool as an experimental tool is a delight.

On Thu, Feb 22, 2024 at 20:07 Mike Lissner @.***> wrote:

Looks like we've got issues with our build unrelated to this PR. @cbrew https://github.com/cbrew, do I guess correctly that you'd rather not go down this rabbit hole? If so, I can ask somebody on our staff to do so, or it's possible @mattdahl https://github.com/mattdahl might be game.

— Reply to this email directly, view it on GitHub https://github.com/freelawproject/eyecite/pull/168#issuecomment-1960597778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFIW2R2ALRGLWH6QCKWYHTYU7TTZAVCNFSM6AAAAABDPUJBA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGU4TONZXHA . You are receiving this because you were mentioned.Message ID: @.***>

mlissner commented 7 months ago

No worries! One of our devs fixed the testing problem (hopefully).

Now the only issue is that your code isn't passing the linting rule for a very minor reason. Mind fixing that and then we'll be good to go?

cbrew commented 7 months ago

still getting a mystery error about "resource not accessible ny integration'

mlissner commented 7 months ago

@ERosendo can you take another look at getting this one over the hump, please?

Thanks Chris!

ERosendo commented 7 months ago

@mlissner I've updated this PR and I've made some minor code changes to avoid unnecessary updates to the poetry.lock file. All tests are passing and the linting check is successful.

I believe the current issue with the Benchmark Pull Request check is related to token permissions. Workflows triggered by pull requests from forked repositories use a read-only token and all other secrets are not available to the workflow run. This means any attempts to write, such as creating comments on the pull request using GITHUB_TOKEN or other secrets, will fail.

mlissner commented 7 months ago

Excellent, thank you, merging!