Open voutilad opened 7 years ago
There are a lot more problems than just this when trying to run Juriscraper in Python 3. Tried running:
python3 setup.py test
Are python2 and python3 compatibility desired?
Py3 is desired in the broad sense, but "nobody" is asking for it yet. Until CourtListener itself is Py3 ready, doing Juriscraper is good, but not a huge thing. IIRC, we turned off Travis testing for py3 a while back and with a lot of sadness.
All of that said, I'm totally in favor of and enthusiastic about Py3 compatibility, especially if, like here, it sounds fairly easy.
in https://github.com/freelawproject/juriscraper/commit/c7b6fef5b9e7177481542be7651ac35aa5571aa3 @mlissner cited requests-mock (which now seems to be python3 over at https://github.com/jamielennox/requests-mock) and jsondate, which doesn't seem likely to get updated on its own (https://github.com/rconradharris/jsondate/issues/7)
If jsondate is the only issue, I wonder if the easiest path here is either:
Forking and hosting our own version of jsondate (as sometimes happens when py2 stuff is abandoned), or
Dropping our dependency on it and figuring out a different way forward.
I think either should be fairly simple. I don't think we do a ton with jsondate.
Thanks for doing the digging on this, @jcrben.
Some scrapers still have potentially issue-prone regex patterns that could be an issue in Py3.7+. Guess I didn't catch these before.
Simple fix is to set these string literals to raw string literals.