search

freelawproject / recap-safari

GNU General Public License v3.0
0 stars 2 forks source link

Convert Chrome extension to Safari #3

Open freelawbot opened 9 years ago

freelawbot commented 9 years ago

Issue by PlainSite Friday Jul 18, 2014 at 20:59 GMT Originally opened as https://github.com/freelawproject/recap-extension-2.0/issues/9

Supposedly it's not a very difficult process to convert a Chrome extension to a Safari one, or so says Apple...

https://developer.apple.com/library/safari/documentation/userexperience/conceptual/safariextensionsconversionguide/chapters/chrome.html

(I just ditched Firefox after using it for 13 years. Too slow and makes my Mac sound like a jet engine all the time.)

freelawbot commented 9 years ago

Comment by mlissner Friday Jul 18, 2014 at 21:54 GMT

I think this will be a possibility, but not a requirement for 2.0.

mlissner commented 7 years ago

This probably works — opera did. We need somebody to test though and to commit to testing/filing issues in the future.

I don't have an Apple computer and don't know how to install a dev extension, but it's probably pretty easy.

j-f1 commented 3 years ago

There’s a new tool to help get this working https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari

mlissner commented 3 years ago

Any interest in taking a stab at it, @j-f1? We're looking for a maintainer for the Safari version. So far, no luck finding somebody.

flooie commented 3 years ago

@mlissner

I went ahead and started the process @j-f1. If you are interested, the first conversion required removing a couple things from the manifest, but does run and does search courtlistener.com.

I have not tried the more important and complex features at this point though.

j-f1 commented 3 years ago

I gave it a shot and it seems to have uploaded from PACER properly: https://www.courtlistener.com/docket/18535825/the-toronto-dominion-bank-v-plaid-inc/#minute-entry-158863877

mlissner commented 3 years ago

@j-f1, if you want to do some manual testing, we have a not-too-hard-nor-too-formal process here that you could work your way through: https://github.com/freelawproject/recap/wiki/QA-Testing

We'll probably go through it too before releasing our beta, but more eyes would surely be helpful.

flooie commented 3 years ago

@j-f1 thank you! I haven't taken it for a drive yet, but I'm experiencing the beach ball shortly after clicking the popup most times (give or take). I was wondering if you were having a similar experience?

j-f1 commented 3 years ago

No such issues on courtlistener.com on Safari Technology Preview.

j-f1 commented 3 years ago

I looked through the steps. Some notes:

Everything else seems fine. I stopped at “Uploads” for now.

flooie commented 3 years ago

@j-f1 - I had the same issue - it will take a slight tweak in the content delegate

The line below thinks its chrome and tries to use content.fetch when safari needs window.fetch.

from

  const browserSpecificFetch = (navigator.userAgent.indexOf('Chrome') < 0) ? content.fetch : window.fetch;

to ... or some variation

  const browserSpecificFetch = window.fetch; // <--- this is an change that should be addressed
mlissner commented 3 years ago

Funny that browserSpecificFetch strikes again. If only browsers could just do this one thing the same way. I think this is one of very few shims that we have.

flooie commented 3 years ago

@j-f1 I can't seem to get over how slow it is to open the extension on my computer. Do you get any lag - any slowness in opening and toggling the extension?

j-f1 commented 3 years ago

Nothing too bad — maybe about a second when clicking the toolbar button on a supported website but no freezing