search

freelawproject / recap

This repository is for filing issues on any RECAP-related effort.
https://free.law/recap/
12 stars 4 forks source link

Adding [R] icons lacks idempotency #258

Closed johnhawkinson closed 5 years ago

johnhawkinson commented 6 years ago

Restarting/reloading the extension can cause a page to be tagged multiple times. That should not happen. Here's an extreme example:

screen shot 2018-08-15 at 09 48 34
mlissner commented 6 years ago

I'm not sure how to stop this, but it sure would be nice to do so.

Mike Lissner Executive Director Free Law Project https://free.law

On Wed, Aug 15, 2018 at 6:49 AM John Hawkinson notifications@github.com wrote:

Restarting/reloading the extension can cause a page to be tagged multiple times. That should not happen. Here's an extreme example:

[image: screen shot 2018-08-15 at 09 48 34] https://user-images.githubusercontent.com/1270718/44151404-7a4afaae-a070-11e8-96cf-7155177db786.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/258, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOdqj4VpGRSGVOLvIqwEe13-fZKDmsXks5uRCbmgaJpZM4V-IwN .

johnhawkinson commented 6 years ago

Oh, it's pretty easy. The extension should just check for an existing [R] link before adding one. There are some choices to be made about whether we should just skip checking on a pagewide basis (but what if there are more recent changes), or only check un-linked doc1s, or re-check existing doc1s and replace existing links. But none of that's hard.

mlissner commented 6 years ago

Oh yeah, that'd work. I was thinking of something more complicated, but that seems simple enough. +1

Mike Lissner Executive Director Free Law Project https://free.law

On Wed, Aug 15, 2018 at 9:15 AM John Hawkinson notifications@github.com wrote:

Oh, it's pretty easy. The extension should just check for an existing [R] link before adding one. There are some choices to be made about whether we should just skip checking on a pagewide basis (but what if there are more recent changes), or only check un-linked doc1s, or re-check existing doc1s and replace existing links. But none of that's hard.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/258#issuecomment-413248779, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOdquxgg3FrjtHDalOPPvmrWCL2qNJTks5uREkrgaJpZM4V-IwN .

mlissner commented 5 years ago

Dup of #223.