search

freelawproject / recap

This repository is for filing issues on any RECAP-related effort.
https://free.law/recap/
12 stars 4 forks source link

[Firefox-Addon,Bug] California Central District Court failing to load with RECAP enabled #279

Closed masterX244 closed 4 years ago

masterX244 commented 4 years ago

On the CACD of california RECAP causes only a "infinite" waiting for document page instead of showing the PDF Example Document https://ecf.cacd.uscourts.gov/doc1/031031686578?caseid=748605

csnardi commented 4 years ago

This is happening for me too on all PACER documents in Chrome. Not sure if it's the same issue though. Warning in DevTools:

utils.js:121 Cross-Origin Read Blocking (CORB) blocked cross-origin response <URL removed> with MIME type application/pdf. See https://www.chromestatus.com/feature/5629709824032768 for more details.
knowtheory commented 4 years ago

Yeah seems like the solution to this is going to be moving the content fetching into a background worker:

https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

I'll try to find the Firefox docs that track with this: https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

mlissner commented 4 years ago

Hm, I went to:

https://ecf.cacd.uscourts.gov/doc1/031031686578?caseid=748605

And was completely able to get the document in Chrome 78 with RECAP installed.

Meanwhile, our average downloads seem about on target. I'd love to figure out what setting we need to tweak here. Is everybody on Chrome 78?

csnardi commented 4 years ago

I'm on Chrome dev (79).

mlissner commented 4 years ago

OK, yep, I see it on 79, which comes out on December 10th.

mlissner commented 4 years ago

@masterX244 are you on 79 as well?

mlissner commented 4 years ago

Yeah, it looks like @knowtheory's um...theory is right, and the docs at that link have the answer. The big picture is that starting in Chrome 79, content scripts can't do AJAX fetches anymore. Instead, you have to ask a background page to do it for you by sending a message to it. The docs have an example of that, and it looks straightforward. @knowtheory's approach seems like it'd work too and probably be better, but also seems like more work, I think. Worth it though if it brings other benefits.

masterX244 commented 4 years ago

Firefox here. 69 back when i wrote the issue

Mike Lissner notifications@github.com schrieb am Mi., 30. Okt. 2019, 01:20:

@masterX244 https://github.com/masterX244 are you on 79 as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/279?email_source=notifications&email_token=AALZFWWHEIIJIHLCZSXFDRDQRDHMFA5CNFSM4JCTS5C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSQI7Q#issuecomment-547685502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZFWWEUU4L76XJNLJBZ43QRDHMFANCNFSM4JCTS5CQ .

mlissner commented 4 years ago

@masterX244 on FF70, I have zero issues with that link. Can you see if you're all good or still hung up? I suspect your issue may be different (and more individualized) than the one mentioned by @csnardi. If you're still hung up, can you try disabling other extensions, VPNs, etc?

masterX244 commented 4 years ago

Found out that it manages to retrieve the file and then fails between line 429 and 431 of content_delegate.js

Clean profile works but main profile with all addons except Recap blocked in private mode windows and then using private window fails to work. Not using any VPN stuff for browsing at all. Only a local PI-hole but that should not matter since the clean profile test shows that stuff is working with it.

mlissner commented 4 years ago

For the issue affecting @csnardi (and all Chrome 79 users), I just split it off into #280. @masterX244, this issue is yours again.

mlissner commented 4 years ago

@masterX244 Is there a specific error you're getting that makes you think it's on line 430 of content_delegate.js?

masterX244 commented 4 years ago

breakpoints. 429 is last one that breaks. The next breakable line is never reached

Mike Lissner notifications@github.com schrieb am Do., 31. Okt. 2019, 23:44:

@masterX244 https://github.com/masterX244 Is there a specific error you're getting that makes you think it's on line 430 of content_delegate.js?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/279?email_source=notifications&email_token=AALZFWS3A2PMTYAZBXWFOR3QRNNVXA5CNFSM4JCTS5C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZPDSA#issuecomment-548598216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZFWRUVIXRBYGSKNPWVYDQRNNVXANCNFSM4JCTS5CQ .

johnhawkinson commented 4 years ago

429 is kind of a lot of complicated expressions:

https://github.com/freelawproject/recap-chrome/blob/18719f17ba23b478263d7228ae9555ad9eb9b2b6/src/content_delegate.js#L429-L500

@masterX244, do you have a dev tree? Can you wrap it in a try/catch block and print the exception?

masterX244 commented 4 years ago

No exception if i wrap that method call into a try-catch.

Am Fr., 1. Nov. 2019 um 00:50 Uhr schrieb John Hawkinson < notifications@github.com>:

429 is kind of a lot of complicated expressions:

https://github.com/freelawproject/recap-chrome/blob/18719f17ba23b478263d7228ae9555ad9eb9b2b6/src/content_delegate.js#L429-L500

@masterX244 https://github.com/masterX244, do you have a dev tree? Can you wrap it in a try/catch block and print the exception?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/279?email_source=notifications&email_token=AALZFWRHCXHXHQKFTYO3KH3QRNVLLA5CNFSM4JCTS5C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZSZVY#issuecomment-548613335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZFWXT7QNAX2TTPN4SDI3QRNVLLANCNFSM4JCTS5CQ .

masterX244 commented 4 years ago

Found the cause. If you got bitten by this FF bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1244038 you need to eradicate the storage folder from the profile. Somehow it FUBARs something so the recap addon cannot do its magic

Am Fr., 1. Nov. 2019 um 13:53 Uhr schrieb Tom Goerner <masterx244@gmail.com

:

No exception if i wrap that method call into a try-catch.

Am Fr., 1. Nov. 2019 um 00:50 Uhr schrieb John Hawkinson < notifications@github.com>:

429 is kind of a lot of complicated expressions:

https://github.com/freelawproject/recap-chrome/blob/18719f17ba23b478263d7228ae9555ad9eb9b2b6/src/content_delegate.js#L429-L500

@masterX244 https://github.com/masterX244, do you have a dev tree? Can you wrap it in a try/catch block and print the exception?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/279?email_source=notifications&email_token=AALZFWRHCXHXHQKFTYO3KH3QRNVLLA5CNFSM4JCTS5C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZSZVY#issuecomment-548613335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZFWXT7QNAX2TTPN4SDI3QRNVLLANCNFSM4JCTS5CQ .

mlissner commented 4 years ago

That's...odd, @masterX244. I'm glad you got it, but why would a four-year-old bug crop up for you? Are you a really heavy RECAP user?

masterX244 commented 4 years ago

That bug was very fresh. I linked the wrong one. It was one that struck around 69 to 70. ==> https://bugzilla.mozilla.org/show_bug.cgi?id=1592136. It probably already slumbered inside the data of my FF profile. Same bug caused other issues for me after the FF70 upgrade, thats why i researched around it. That other report was next to the fresh one thats why i mixxed those up.

Am Fr., 1. Nov. 2019 um 23:43 Uhr schrieb Mike Lissner < notifications@github.com>:

That's...odd, @masterX244 https://github.com/masterX244. I'm glad you got it, but why would a four-year-old bug crop up for you? Are you a really heavy RECAP user?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freelawproject/recap/issues/279?email_source=notifications&email_token=AALZFWQOBLPLYLYYQRIEL3DQRSWK3A5CNFSM4JCTS5C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4LCTQ#issuecomment-548974926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZFWQATFFFKMXMV2YEMXTQRSWK3ANCNFSM4JCTS5CQ .

mlissner commented 4 years ago

Got it! Thanks for documenting this. I'm going to close this down since (thankfully!) you were able to get this figured out, and it's not something related to us. Whew!